[PATCH] D44225: Fix identification of COFF executable files
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 7 13:46:11 PST 2018
zturner added a comment.
In https://reviews.llvm.org/D44225#1030532, @rnk wrote:
> I did some archaelogy and found that this is from https://reviews.llvm.org/rL128799, committed by @echristo on behalf of Graydon Hoare. I think we should just go ahead and remove the "PE" check.
It's true that file magic checks are heuristic, but having it rely on only 2 bytes will have quite a lot of false positives on binary files.
https://reviews.llvm.org/D44225
More information about the llvm-commits
mailing list