[PATCH] D44112: TableGen: Type-check BinOps

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

This change should come with an update to the docs.

One thing jumped at me -- we have three different variants of concatenation -- !con, !listconcat and !strconcat (along with '#'). Do we need all of them? I think we could get by with one, which would glue together items of the same kind.



================
Comment at: test/TableGen/Paste.td:15-24
+class Arithmetic<int i> {
+  string name = "number"#!add(i, 1);
+}
+
+def A : Arithmetic<5>;
+
+// CHECK: def A {
----------------
This does not seem to test anything relevant to this patch.Was this change supposed to be here or in some other patch?


================
Comment at: test/TableGen/arithmetic.td:14
+
+def A0 : A<63, 1>;
----------------
I'm not sure if this file was meant to be in this patch. It does not seem to use 3+operand variants of !con, !add, !and, !or.


Repository:
  rL LLVM

https://reviews.llvm.org/D44112