[PATCH] D44216: [LangRef] make it clear that FP instructions do not have side effects
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 7 11:51:36 PST 2018
spatel added inline comments.
================
Comment at: docs/LangRef.rst:3041
+ %A = fadd undef, %X
%B = fdiv %X, undef
Safe:
----------------
efriedma wrote:
> I would rather just rewrite this example so it doesn't use fdiv.
>
> You can make the point this paragraph is trying to make much more clearly and unambiguously using integer sdiv rather than floating-point operations.
Yes, good point. Do you think there's value in also having the FP examples here to explicitly show the difference between int and FP, or are the additions to the opcode definitions enough?
https://reviews.llvm.org/D44216
More information about the llvm-commits
mailing list