[PATCH] D44192: Proper handling of Itanium mangled names in LLVMSymbolizer on Windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: ruiu.
rnk added inline comments.


================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:477
+#if defined(_MSC_VER)
+    char *DemangledName = itaniumDemangle(Name.c_str(), nullptr, nullptr, &status);
+#else
----------------
I think we should use `itaniumDemangle` everywhere so that we have consistent behavior across platforms. At some point, we may be able to add @ruiu's MS demangler below so that we can demangle MS C++ symbols on Linux.


Repository:
  rL LLVM

https://reviews.llvm.org/D44192