[PATCH] D44201: [WebAssembly] Disallow weak undefined globals in the object format

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

LGTM, with comments.



================
Comment at: lib/Object/WasmObjectFile.cpp:426
+      if (!IsDefined &&
+          (Info.Flags & wasm::WASM_SYMBOL_BINDING_MASK) ==
+              wasm::WASM_SYMBOL_BINDING_WEAK)
----------------
Add and test for this error maybe?

Should the error be more specific?

Do we also want to add an error to MC/WasmObjectWriter.cpp?


Repository:
  rL LLVM

https://reviews.llvm.org/D44201