[PATCH] D44206: [WebAssembly] Create SyntheticFunction for __wasm_call_ctors earlier

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In https://reviews.llvm.org/D44206#1030142, @ruiu wrote:

> If that's the case, I don't think just putting a .ctor at beginning of a file is not enough. You probably should sort functions by topological order so that the functions and data that a .ctor needs are available early.


I don't see that as the reason for this change.  This seems like more of refactor to make the code cleaner and more re-usable.  Nicolas has another change pending that will add synthetic functions to allow weak undefined functions to be called which builds on the generality in this change.

I fact, this change doesn't change the order of any functions, as can be seen by the fact that no unit tests changed.

@ncw, and you add `NFC` to the title and update the title and the description to more accurately describe what this change does.  Its not really just about the __wasm_call_ctors, and it doesn't effect the ordering in the file, right?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44206