[PATCH] D44215: [Support] Move syntax highlighting into support

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 7 09:44:55 PST 2018


davide added a comment.

Makes sense to me, can you do the formatting separately?



================
Comment at: llvm/include/llvm/Support/SyntaxHighlighting.h:32-33
 
-/// An RAII object that temporarily switches an output stream to a
-/// specific color.
+/// An RAII object that temporarily switches an output stream to a specific
+/// color.
 class WithColor {
----------------
unrelated formatting change?


================
Comment at: llvm/lib/Support/SyntaxHighlighting.cpp:32-58
+    case Address:
+      OS.changeColor(raw_ostream::YELLOW);
+      break;
+    case String:
+      OS.changeColor(raw_ostream::GREEN);
+      break;
+    case Tag:
----------------
these formatting changes are unrelated I assume? If so, can you split?


Repository:
  rL LLVM

https://reviews.llvm.org/D44215





More information about the llvm-commits mailing list