[PATCH] D43865: [NewGVN] Create new ValuePHI node, if the number of operands does not match.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D43865#1028755, @dberlin wrote:

> At a minimum, the patch needs bootstrap and testing, i didn't test it except on this case and test/Transforms/NewGVN.
>  :)


Done!

With and without this patch, bootstrapping clang/llvm fails with "value number changed after ..." assertions. I finally took the time and re-visited https://reviews.llvm.org/D42180. One case we seem to miss is when changes to the translated operands of the ValueOp cause us to find a leader for the ValueOp, for which we previously did not find a leader and returned early. In this case no additional users are added to trigger re-evaluation of the phi node.

Together with https://reviews.llvm.org/D42180, bootstrapping passed. And also running the test-suite.


https://reviews.llvm.org/D43865