[lld] r326892 - [ELF] - Report LMA region overflows.
George Rimar via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 7 03:54:30 PST 2018
Author: grimar
Date: Wed Mar 7 03:54:30 2018
New Revision: 326892
URL: http://llvm.org/viewvc/llvm-project?rev=326892&view=rev
Log:
[ELF] - Report LMA region overflows.
We do not report LMA region overflows currently.
Both GNU linkers do that. The patch implements it.
Differential revision: https://reviews.llvm.org/D44094
Added:
lld/trunk/test/ELF/linkerscript/lma-overflow.test
Modified:
lld/trunk/ELF/LinkerScript.cpp
Modified: lld/trunk/ELF/LinkerScript.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=326892&r1=326891&r2=326892&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.cpp (original)
+++ lld/trunk/ELF/LinkerScript.cpp Wed Mar 7 03:54:30 2018
@@ -117,9 +117,9 @@ void LinkerScript::expandOutputSection(u
if (Ctx->MemRegion)
expandMemoryRegion(Ctx->MemRegion, Size, Ctx->MemRegion->Name,
Ctx->OutSec->Name);
- // FIXME: check LMA region overflow too.
if (Ctx->LMARegion)
- Ctx->LMARegion->CurPos += Size;
+ expandMemoryRegion(Ctx->LMARegion, Size, Ctx->LMARegion->Name,
+ Ctx->OutSec->Name);
}
void LinkerScript::setDot(Expr E, const Twine &Loc, bool InSec) {
Added: lld/trunk/test/ELF/linkerscript/lma-overflow.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/linkerscript/lma-overflow.test?rev=326892&view=auto
==============================================================================
--- lld/trunk/test/ELF/linkerscript/lma-overflow.test (added)
+++ lld/trunk/test/ELF/linkerscript/lma-overflow.test Wed Mar 7 03:54:30 2018
@@ -0,0 +1,17 @@
+# REQUIRES: x86
+
+# echo '.section .foo,"a"; .quad 1' | llvm-mc -filetype=obj -triple=x86_64-unknown-linux - -o %t.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %t.s -o %t.o
+# RUN: not ld.lld -o %t %t.o --script %s 2>&1 | FileCheck %s
+# CHECK: error: section '.foo' will not fit in region 'flash': overflowed by 264 bytes
+
+MEMORY {
+ ram (rwx) : org = 0x1000, len = 0x300
+ flash (rwx) : org = 0x1000, len = 0x100
+}
+SECTIONS {
+ .foo : {
+ *(.foo)
+ . += 0x200;
+ } > ram AT>flash
+}
More information about the llvm-commits
mailing list