[PATCH] D44180: Improve --warn-symbol-ordering.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

Overall direction and ICF related change looks good.

> -      if (auto *Sec = dyn_cast_or_null<InputSectionBase>(D->Section)) {
> -        int &Priority = SectionOrder[cast<InputSectionBase>(Sec->Repl)];
> -        Priority = std::min(Priority, Ent.Priority);
> +      auto *Sec = dyn_cast_or_null<InputSectionBase>(cast<Defined>(Sym)->Section);
> +      if (!Sec) {
> +        Warn("unable to order absolute symbol");

This will fire for symbols like _GLOBAL_OFFSET_TABLE_ that point to an
OutputSection, no?

Cheers,
Rafael