[PATCH] D44004: [ELF] - Show data commands in the map file.

[Rafael Avila de Espindola via llvm-commits]

George Rimar via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> +# RUN: ld.lld -o %t %t.o -Map=%t.map --script %s
> +# RUN: FileCheck -strict-whitespace %s < %t.map

Why do you need -strict-whitespace? The fact that you have a newline in
0x123 * (1+1) should be sufficient, no?


> +  // Keeps string representing the expression. Used when printing map file.
> +  StringRef StringView;
> +
> +  unsigned Offset;
> +  unsigned Size;

Add a comment about Offset and Size. Looking at a SymbolAssignment one
could assume Offset is the offset in a section and Size the size of the
elf symbol.

Cheers,
Rafael