[PATCH] D43505: [docs] Use literalinclude for most code in the Kaleidoscope tutorial to ensure the code always compiles and is up to date

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 14:25:24 PST 2018


Tanya Lattner is the one currently maintaining the automatic docs
builder for attributes (and I believe compiler flags as well) and I
think Dmitri Gribenko maintains the actual bots (clang-sphinx-docs,
llvm-sphinx-docs, etc).

I'm not certain what version we're building with currently -- I
couldn't find the information in any of my emails. I think 1.6 was
released in May 2017 which seems a bit recent for it being a minimum
requirement. That said, I don't have Opinions on whether to bump the
min version or not.

~Aaron

On Tue, Mar 6, 2018 at 2:43 PM, David Blaikie <dblaikie at gmail.com> wrote:
> Hey Aaron (Ballman) - do you happen to know who maintains sphinx bots, etc?
> Wondering if we can reasonably require a certain version (looks like there's
> a feature in 1.6 that could be handy).
>
> On Tue, Feb 27, 2018 at 2:13 AM Aron Granberg via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> Voxel added a comment.
>>
>> I found that there is apparently a config file that can be used to set the
>> minimum sphinx version that is required.
>>
>> It can be found in the llvm/docs/conf.py file:
>>
>>   # If your documentation needs a minimal Sphinx version, state it here.
>>   #needs_sphinx = '1.0'
>>
>> Currently it is not set, but I suppose one option would be to set that to
>> 1.6 to at least ensure that anyone who tries to build the docs with an
>> outdated version of sphinx will get an error message.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D43505
>>
>>
>>
>


More information about the llvm-commits mailing list