[PATCH] D44175: Add std:: to begin and end in drop_begin

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Unit tests would be good, and adding "std::" actually would break the ADL-based lookup possibilities (eg: the intent of the free-function begin/end API is to allow, say "my_namespace::vector" to be usable with "my_namespace::begin").

What we probably need is some kind of adl_begin/adl_end functions that wrap up this functionality for easy reuse throughout our STL helpers/wrapper/etc. Though I haven't given a lot of thought to how easy/hard that'd be to implement :/


Repository:
  rL LLVM

https://reviews.llvm.org/D44175