[PATCH] D42516: [llvm-objcopy] Add support for large indexes
Jake Ehrlich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 6 14:01:21 PST 2018
jakehehrlich added a comment.
> In https://reviews.llvm.org/D42516#1021711, @jakehehrlich wrote:
>
>> It's not an ideal test but to test that
>
>
> I think you forgot to end a sentence :)
I don't remember exactly what I wanted to say but basically I'm not sure adding more tests is worth it because there are many challenges in adding this sort test.
> Also I don't see any comment about number 6?
It requires uploading another binary which isn't ideal. It's also hard to produce.
Repository:
rL LLVM
https://reviews.llvm.org/D42516
More information about the llvm-commits
mailing list