[PATCH] D44111: TableGen: Allow ? in lists

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

One test nit. Perhaps should be fixed in a separate patch before this one. LGTM otherwise.



================
Comment at: test/TableGen/dag-functional.td:11
 // CHECK: def A1 {
-//   dag ret = (ops 1:$a, 2:$b);
+//   dag ret = (ops ?:$a, 1:$b, 2);
 // }
----------------
I assume we do care about the value of the `dag ret`, not just the fact that the record got defined. If so, I think there's a CHECK missing here and in the rest of the checks in the file.


Repository:
  rL LLVM

https://reviews.llvm.org/D44111