[PATCH] D44171: [scudo] Make logging more consistent

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad created this revision.
cryptoad added reviewers: alekseyshl, flowerhack.
Herald added subscribers: Sanitizers, delcypher, mgorny.

A few changes related to logging:

- prepend `Scudo` to the error messages so that users can identify that we reported an error;
- replace a couple of `Report` calls in the RSS check code with `dieWithMessage`/`Print`, mark a condition as `UNLIKELY` in the process;
- change some messages so that they all look more or less the same. This includes the `CHECK` message;
- adapt a couple of tests with the new strings.

A couple of side notes: this results in a few 1-line-blocks, for which I left
brackets. There doesn't seem to be any style guide for that, I can remove them
if need be. I didn't use `SanitizerToolName` in the strings, but directly
`Scudo` because we are the only users, I could change that too.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44171

Files:
  lib/scudo/CMakeLists.txt
  lib/scudo/scudo_allocator.cpp
  lib/scudo/scudo_termination.cpp
  lib/scudo/scudo_utils.cpp
  test/scudo/alignment.c
  test/scudo/sized-delete.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44171.137251.patch
Type: text/x-patch
Size: 9916 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180306/e4d5f87e/attachment.bin>