[PATCH] D44028: [WebAssembly] Handle weak undefined globals and functions

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: test/wasm/undefined-weak-call.test:1
+# RUN: yaml2obj %s > %t.o
+# RUN: not lld -flavor wasm --no-entry %t.o -o %t.wasm 2>&1 | FileCheck %s
----------------
Use of yaml2obj is not encouraged. Is there any way to write it in .s or in .ll?


================
Comment at: test/wasm/undefined-weak-call.test:2
+# RUN: yaml2obj %s > %t.o
+# RUN: not lld -flavor wasm --no-entry %t.o -o %t.wasm 2>&1 | FileCheck %s
+
----------------
Please use wasm-ld. `lld` as a command is essentially deprecated.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44028