[PATCH] D44149: [WebAssembly] Use StringSaver to retain ownership of ctor function body. NFC
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 6 12:07:06 PST 2018
sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: wasm/InputChunks.h:159
StringRef getName() const override { return Name; }
+ StringRef getComdat() const override { return StringRef(); }
----------------
Why add getComdat() here? If we really want this to be NFC maybe this part should be separate.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44149
More information about the llvm-commits
mailing list