[PATCH] D44146: [WebAssembly] Remove duplicated line of code and unreachable check. NFC
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 6 11:46:01 PST 2018
sbc100 added inline comments.
================
Comment at: wasm/Writer.cpp:696
continue;
- if (!Sym->isLive())
- return;
+ assert(Sym->isLive());
Sym->setOutputSymbolIndex(SymbolIndex++);
----------------
But this isn't iterating the symbol table, its iterating all symbols in all the objects. Surely some of them can be non-live. I don't quite understand why we not hitting this case in some unit test.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44146
More information about the llvm-commits
mailing list