[PATCH] D42960: [ELF] Add .eh_frame pieces to map file

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 6 10:18:57 PST 2018


ruiu added inline comments.


================
Comment at: ELF/MapFile.cpp:143
+        InputSectionBase *ISec = nullptr;
+        uint64_t InputStart = 0, InputEnd = 0, OutputStart = 0, OutputEnd = 0;
+
----------------
As I said, please try to make your new code look the same as the existing code. For example, we don't define multiple local variables in one line like this in other places.


https://reviews.llvm.org/D42960





More information about the llvm-commits mailing list