[PATCH] D43515: More math intrinsics for conservative math handling

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: docs/LangRef.rst:13337
+      declare <type>
+      @llvm.experimental.constrained.extend(<type> <op>,
+                                          metadata <rounding mode>,
----------------
kpn wrote:
> andrew.w.kaylor wrote:
> > kpn wrote:
> > > andrew.w.kaylor wrote:
> > > > This is a replacement for fpext, right? I think you should say that somewhere.
> > > I think I picked names for the intrinsics that matched the SelectionDAG node enum. Perhaps it would be better to match the bitcode language names? In which case this intrinsic would be "fpext" instead of "extend".
> > > 
> > > Either way that's a good idea for the documentation to at least mention fpext.
> > These intrinsics should be driven by what the front end needs. If no front end is generating an equivalent now then we don't want an intrinsic. So, yes, please match the bitcode language names.
> Will do.
Say, now that I think about this, what does rounding have to do with extending a FP value? Shouldn't this intrinsic just plain not have rounding metadata?


Repository:
  rL LLVM

https://reviews.llvm.org/D43515