[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Seems OK as an intermediate step - what's your end-goal/plan? I would think this would need to be merged in some way with existing range list support so that things like the symbolizer can work with DWARF 5? (see DWARFUnit::extractRangeList and DWARFDie::getAddressRanges for example)



================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:100
     case dwarf::DW_RLE_end_of_list:
+      CurrentRanges.emplace_back(RangeListEntry{EntryOffset, Encoding});
       Ranges.insert(Ranges.end(), CurrentRanges);
----------------
It's probably better to use push_back rather than emplace_back, if both are valid. (they'll be both as efficient, but emplace_back can do explicit conversions where push_back can only do implicit conversions - so it's simpler, there's less "going on")


https://reviews.llvm.org/D43366