[PATCH] D44106: TableGen: More helpful error messages

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

One nit. LGTM otherwise.



================
Comment at: lib/TableGen/Record.cpp:1839
+      if (Value.setValue(VR)) {
+        std::string Type;
+        if (TypedInit *VRT = dyn_cast<TypedInit>(VR))
----------------
You are constructing a std::string only to use it  to build another Twine. Why not just use Twine here?


Repository:
  rL LLVM

https://reviews.llvm.org/D44106