[PATCH] D43753: TableGen: Allow !cast of records, cleanup conversion machinery

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: docs/TableGen/LangIntro.rst:186
+    If 'a' is a string, a symbol of type *type* obtained by looking up the
+    string 'a' in the symbol table.  If the type of 'a' does not match *type*,
+    TableGen aborts with an error. Otherwise, perform a normal type cast e.g.
----------------
nhaehnle wrote:
> tra wrote:
> > `symbol table` may need some disambiguation.  I.e. we have more than one kind of symbols (template parameters, class/multiclass names, field names, defined records, temporary variables in !foreach) and not all of them are applicable here.
> > 
> > Does it mean `list of all records defined by the time tablegen reaches the end of its input`?
> I've tried to make the rules more explicit.
Nice. That's a huge improvement over the old description.


Repository:
  rL LLVM

https://reviews.llvm.org/D43753