[PATCH] D44116: [CodeView] Emit UdtSourceLine information for enums

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 13:24:39 PST 2018


rnk added a comment.

We also probably need to emit `S_UDT` symbol records in the right place. Can you factor out a method with this code from `lowerCompleteTypeClass` and make Class, Enum, and Union code call it? This is the duplicated code that has already diverged a little bit:

  if (const auto *File = Ty->getFile()) {
    StringIdRecord SIDR(TypeIndex(0x0), getFullFilepath(File));
    TypeIndex SIDI = TypeTable.writeLeafType(SIDR);
  
    UdtSourceLineRecord USLR(ClassTI, SIDI, Ty->getLine());
    TypeTable.writeLeafType(USLR);
  }
  
  addToUDTs(Ty);


Repository:
  rL LLVM

https://reviews.llvm.org/D44116





More information about the llvm-commits mailing list