[PATCH] D44054: [DWARFv5] Emit file 0 to the line table.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1119
+    MD5::MD5Result *Checksum, Optional<StringRef> Source, unsigned CUID) {
+  assert(CUID == 0);
+
----------------
probinson wrote:
> aprantl wrote:
> > That looks odd — is that a placeholder for later?
> No, it's because asm output doesn't know how to distinguish multiple compile units in the line table.  The corresponding MCStreamer (direct-to-object) method can handle different CUIDs.
Perhaps add a `&& "not supported by MCAsmStreamer"` for clarity?


https://reviews.llvm.org/D44054