[PATCH] D39976: [AArch64] Query the target when folding loads and stores

[Evandro Menezes via Phabricator via llvm-commits]

evandro added a comment.

In https://reviews.llvm.org/D39976#1027475, @gberry wrote:

> In https://reviews.llvm.org/D39976#1017864, @evandro wrote:
>
> > Methinks that the gist is to move away from features and to rely more on the cost model.  In the case of this patch, it also removes the feature `FeatureSlowPaired128` in https://reviews.llvm.org/D40107.
>
>
> That seems like a worthwhile goal, but this change doesn't really seem to be accomplishing that.  If the sched model is being used by a subtarget-specific heuristic, that seems like just a more roundabout way of achieving the same result for your subtarget.  Is there any net effect of this change combined with https://reviews.llvm.org/D40107?


`FeatureSlowPaired128` was just too coarse.  The alternative would be to change it to something more specific, like `FeatureSlowSomePaired128Sometimes`, and then create yet another when for the next generation to specialize it further.  Instead, querying the scheduling model seems to be a much more reasonable approach.


https://reviews.llvm.org/D39976