[PATCH] D43582: [SLP] Generalization of stores vectorization.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 11:00:11 PST 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4598
   unsigned E = Stores.size();
-  IndexQueue.resize(E - 1);
+  const unsigned MaxLookDepth = std::max(E - 1, 16u);
+  SmallVector<unsigned, 16> IndexQueue(MaxLookDepth);
----------------
ABataev wrote:
> lebedev.ri wrote:
> > The `std::max()` is not a typo? Might warrant a comment.
> Yes, it is a typo, must be `min`, thanks!
Then you //probably// want to add a test :)


Repository:
  rL LLVM

https://reviews.llvm.org/D43582





More information about the llvm-commits mailing list