[PATCH] D43639: [llvm-pdbdump] Dump restrict type qualifier

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: tools/llvm-pdbutil/PrettyFunctionDumper.cpp:249-252
     if (Symbol.isConstType())
       WithColor(Printer, PDB_ColorItem::Keyword).get() << "const ";
     if (Symbol.isVolatileType())
       WithColor(Printer, PDB_ColorItem::Keyword).get() << "volatile ";
----------------
I'm pretty sure these modifiers go on the other side of the pointee type, like __restrict.


================
Comment at: tools/llvm-pdbutil/PrettyTypedefDumper.cpp:51-54
   if (Symbol.isConstType())
     WithColor(Printer, PDB_ColorItem::Keyword).get() << "const ";
   if (Symbol.isVolatileType())
     WithColor(Printer, PDB_ColorItem::Keyword).get() << "volatile ";
----------------
These probably go on the other side as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D43639