[PATCH] D43736: [AMDGPU] Remove use of OpenCL triple environment and replace with function attribute for AMDGPU

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 08:38:43 PST 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:541
+    const Function &F = MF.getFunction();
+    if (F.hasFnAttribute("amdgpu-implicitarg-num-bytes")) {
+      unsigned Requested = AMDGPU::getIntegerAttribute(
----------------
You don't need this separate check for the attribute existing. getIntegerAttribute essentially does this for you


https://reviews.llvm.org/D43736





More information about the llvm-commits mailing list