[PATCH] D44028: [WebAssembly] Add message for relocation against weak undefined symbol

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 08:32:06 PST 2018


sbc100 added a comment.

How about this for a longer term solution:  When a relocation like this is found the linker can create a linker synthetic function which will abort.. a simple one might be "call_indirect 0" which we know.

For globals I think we can ban weak references, since there is no way to checking the address of a global before calling get_global in it.

I'm happy with the code change for now, but can you write the test as minimal piece of bitcode rather than yaml.  (Is there some reason you didn't do that already?)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44028





More information about the llvm-commits mailing list