[PATCH] D43940: [WebAssembly] Reorder reloc sections to come between symtab and name

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 05:05:47 PST 2018


ncw added a comment.

Committed //without// the change to yaml2wasm.

Sam - are you going to do the work to split the relocs into "chunks", ie explicitly associate them with their function/segment? That would be great if you could do that.

And the link to this issue is, it would be great if at the same time you could change the YAML to put the relocations in the "right" place, rather than associating them with the section they apply to.

That's ultimately the "right" fix for the ordering of the YAML I think. I've reverted by hack in yaml2wasm, it's just not good I agree. If the YAML actually printed the relocations in the same place in the YAML that they appear in the WASM file, that would help out.


Repository:
  rL LLVM

https://reviews.llvm.org/D43940





More information about the llvm-commits mailing list