[PATCH] D43951: [RFC] llvm-mca: a static performance analysis tool.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 5 02:19:38 PST 2018


andreadb added inline comments.


================
Comment at: include/llvm/MC/MCSchedule.h:27-29
-#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
   const char *Name;
-#endif
----------------
MatzeB wrote:
> Do we have an idea how much this increases code size of other llvm tools? If this turns out to be a lot then we may be better of keeping the names either in a separate library or a separate global variables so that the linker can strip them away if unused.
I need to check this.
I expect the impact to be very small, since the number of names per processor tends to be very small. I plan to compare tool sizes before/after to see if the code size increase is negligible or not.


https://reviews.llvm.org/D43951





More information about the llvm-commits mailing list