[PATCH] D43981: [XRay] [compiler-rt] [macosx] Add getTSCFrequency implementation for macOS.
Dean Michael Berris via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 4 16:36:47 PST 2018
dberris added inline comments.
================
Comment at: lib/xray/xray_x86_64.cc:85
+#ifdef SANITIZER_MAC
+ const char* sysctltscname = "machdep.tsc.frequency";
+#else
----------------
Please follow the naming convention around this file -- local variables are TitleCased.
Also, use a function-local static constexpr character array instead of a non-const pointer.
```
static constexpr char SysCtlTSCName[] = "...";
```
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D43981
More information about the llvm-commits
mailing list