[PATCH] D44035: Support OpenBSD in common interceptors
David CARLIER via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 3 04:47:19 PST 2018
devnexen added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:468
+#define SANITIZER_INTERCEPT_FACCESSAT (SI_NETBSD || SI_OPENBSD)
+#define SANITIZER_INTERCEPT_GETGROUPLIST (SI_NETBSD || SI_OPENBSD)
+#define SANITIZER_INTERCEPT_STRLCPY (SI_NETBSD || SI_OPENBSD)
----------------
krytarowski wrote:
> This is wrong.
>
> GETGROUPLIST covers getgroupmembership(3) that is unavailable on OpenBSD. Please split this interceptor.
Fair point
https://reviews.llvm.org/D44035
More information about the llvm-commits
mailing list