[PATCH] D43996: [llvm-objcopy] Implement support for .group sections.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/Object.cpp:396
+  FlagWord = *Word++;
+  for (; Word != End; ++Word) {
+    GroupMembers.push_back(
----------------
jakehehrlich wrote:
> I'm not in love with the existence of initlizeSymbolTable and initlizeRelocations but I think you'll have to do something similar here. Having owned data isn't really what we want. This might be an indication that we need to also pass section data to the initialize method.
right,  Section is kind of breaking down the hierarchy (partially because of the confusing name) now.


Repository:
  rL LLVM

https://reviews.llvm.org/D43996