[PATCH] D44030: [WebAssembly] Tidy up handling of global symbol relocations

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Thanks for the review Sam, I hadn't added you to this one you wouldn't be bothered by //all// my commits!

Things are really pretty snowy here, which is unusual and nice, although quite inconvenient. Have a look at some pics of Britain in the news if you haven't, it's lovely and white.



================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h:91
+// WebAssembly-specific MachineOperand target flags.
+enum WebAssemblyMOTargetFlagVal {
+  MO_NO_FLAG = 0,
----------------
sbc100 wrote:
> Other platforms seem to call this TOF.  Any reason not to follow suit?
If it's inconsistent, it's sheer ignorance! I think I did copy this name from one of the other targets, maybe the wrong one though.

I'll check and fix the name.


Repository:
  rL LLVM

https://reviews.llvm.org/D44030