[llvm] r326541 - [WebAssembly] More uses of uint8_t for single byte values

[Heejin Ahn via llvm-commits]

Thanks! It turned out that the tests were correct and my code was buggy, so
@ncw reverted both the code and the test in r326572.

On Fri, Mar 2, 2018 at 5:56 AM Ilya Biryukov <ibiryukov at google.com> wrote:

> This commit broke test/MC/WebAssembly/global-ctor-dtor.ll, making the
> output of the object file slightly larger.
> I updated the test to unbreak it in r326571, but maybe increased size was
> unintentional, so you might want to take a look.
>
>
> On Fri, Mar 2, 2018 at 7:53 AM Heejin Ahn via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: aheejin
>> Date: Thu Mar  1 22:51:35 2018
>> New Revision: 326541
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=326541&view=rev
>> Log:
>> [WebAssembly] More uses of uint8_t for single byte values
>>
>> Summary: It looks like this was missing from D43921.
>>
>> Reviewers: sbc100
>>
>> Subscribers: jfb, dschuff, jgravelle-google, sunfish, llvm-commits
>>
>> Differential Revision: https://reviews.llvm.org/D43991
>>
>> Modified:
>>
>> llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
>>
>> Modified:
>> llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h?rev=326541&r1=326540&r2=326541&view=diff
>>
>> ==============================================================================
>> ---
>> llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
>> (original)
>> +++
>> llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h
>> Thu Mar  1 22:51:35 2018
>> @@ -158,19 +158,19 @@ static const unsigned LoadP2AlignOperand
>>  static const unsigned StoreP2AlignOperandNo = 0;
>>
>>  /// This is used to indicate block signatures.
>> -enum class ExprType {
>> -  Void    = -0x40,
>> -  I32     = -0x01,
>> -  I64     = -0x02,
>> -  F32     = -0x03,
>> -  F64     = -0x04,
>> -  I8x16   = -0x05,
>> -  I16x8   = -0x06,
>> -  I32x4   = -0x07,
>> -  F32x4   = -0x08,
>> -  B8x16   = -0x09,
>> -  B16x8   = -0x0a,
>> -  B32x4   = -0x0b
>> +enum class ExprType : unsigned {
>> +  Void    = 0x40,
>> +  I32     = 0x7F,
>> +  I64     = 0x7E,
>> +  F32     = 0x7D,
>> +  F64     = 0x7C,
>> +  I8x16   = 0x7B,
>> +  I16x8   = 0x7A,
>> +  I32x4   = 0x79,
>> +  F32x4   = 0x78,
>> +  B8x16   = 0x77,
>> +  B16x8   = 0x76,
>> +  B32x4   = 0x75
>>  };
>>
>>  /// Instruction opcodes emitted via means other than CodeGen.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
> --
> Regards,
> Ilya Biryukov
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180302/b683f1d4/attachment.html>