[PATCH] D42176: [WebAssembly] Optimise relocation iteration to remove n^2 loop. NFC.

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Thanks for looking into improving the comments! :)

In https://reviews.llvm.org/D42176#1024151, @ruiu wrote:

> As to the spec, how much is it fixed at the moment? You said that it's too late, but IIRC, Sam is trying to emit relocation per chunk, instead of emitting a single relocation per file. That's not a file format change?


The Wasm core sections are very fixed, they're used by browsers (Firefox, Chrome, Edge, Safari...) and that boat has sailed. So that includes the way functions and globals are encoded. The bits specific to object files (like relocations) are under our control, and we can still change those. And of course, object files don't have to use a FUNCTION section for functions - but not doing so would be counterintuitive. The FUNCTION section we have no control over, that's set in stone.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42176