[PATCH] D43989: MRI delete command
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 2 10:31:04 PST 2018
Dmitry Mikulin via Phabricator <reviews at reviews.llvm.org> writes:
> // Nothing to do if not saved.
> - if (Saved)
> + if (Saved) {
> performOperation(ReplaceOrInsert, &NewMembers);
> + if (!Members.empty())
> + performOperation(Delete, nullptr);
> + }
> exit(0);
> }
This writes the final archive twice. Please avoid that.
Your patch didn't apply on trunk. I have fixed the conflicts and it is
attached.
Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.diff
Type: text/x-patch
Size: 2111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180302/a0f6f0f9/attachment.bin>
More information about the llvm-commits
mailing list