[PATCH] D43978: Write a hash of the binary as the PE Debug Directory Timestamp
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 2 10:24:14 PST 2018
zturner updated this revision to Diff 136790.
zturner added a comment.
Man, this is hard. There are so many weird edge cases.
Previous version of the patch would continue to write 0 for the timestamp if we weren't generating debug info. But, we really should be writing the time stamp in the coff file header even for non debug info builds. So this version does that.
I'm going to spend some time coming up with a set of tests for all of these edge cases, but throwing this up here in the meantime because I'm probably //still// doing something wrong.
https://reviews.llvm.org/D43978
Files:
lld/COFF/Writer.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43978.136790.patch
Type: text/x-patch
Size: 3939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180302/6761e25c/attachment.bin>
More information about the llvm-commits
mailing list