[PATCH] D44028: [WebAssembly] Add message for relocation against weak undefined symbol
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 2 10:05:32 PST 2018
sbc100 added inline comments.
================
Comment at: wasm/InputFiles.cpp:97
+ Symbol *Sym = getGlobalSymbol(Reloc.Index);
+ if (!Sym->hasOutputIndex()) {
+ // This happens if someone tries to use a `get/set_global` instruction to
----------------
Would it make more sense to check !Sym->isDefined()?
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D44028
More information about the llvm-commits
mailing list