[PATCH] D43945: [dsymutil] Perform analyzeContextInfo and CloneDIEs in parallel

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

As far as I can tell this looks very good, thanks! Fred may have more to say about the algorithmic side.



================
Comment at: tools/dsymutil/DwarfLinker.cpp:1421
+/// associated value is a pair storing the corresponding end PC and the offset
+/// to apply to get the linked address.
+using RangesTy = std::map<uint64_t, std::pair<uint64_t, int64_t>>;
----------------
maybe use a struct instead of a pair for better readability? Up to you.


================
Comment at: tools/dsymutil/DwarfLinker.cpp:2317
       SkipNext = true;
-      Linker.reportWarning(" unsupported relocation in debug_info section.");
+      Linker.reportWarning(" unsupported relocation in debug_info section.",
+                           DMO);
----------------
why does this string need to start with a space?


================
Comment at: tools/dsymutil/DwarfLinker.cpp:4111
+    ObjectContexts.emplace_back(Map, *this, *Obj.get(), Options.Verbose);
+  }
+
----------------
could skip the braces


https://reviews.llvm.org/D43945