[PATCH] D37054: Require address space to be specified when creating functions (2/3)

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 09:37:10 PST 2018


arichardson added a comment.

LGTM but I guess someone else should approve



================
Comment at: lib/AsmParser/LLParser.cpp:1244
   if (Val) {
     if (Val->getType() == Ty) return Val;
+    if (isValidVariableType(M, Ty, Val, /*IsCall=*/true)) return Val;
----------------
This line can be removed since isValidVariableType() does that check too


Repository:
  rL LLVM

https://reviews.llvm.org/D37054





More information about the llvm-commits mailing list