[PATCH] D44023: [WebAssembly] Fix tests with invalid yaml (required CODE section missing)

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 09:06:48 PST 2018


ncw created this revision.
ncw added a reviewer: sbc100.
Herald added subscribers: llvm-commits, sunfish, aheejin, jgravelle-google, dschuff, jfb.

No code change.

----

Split out of https://reviews.llvm.org/D43940 as requested - fixing tests is independent of the validation


Repository:
  rL LLVM

https://reviews.llvm.org/D44023

Files:
  test/ObjectYAML/wasm/export_section.yaml
  test/ObjectYAML/wasm/function_section.yaml
  test/ObjectYAML/wasm/start_section.yaml


Index: test/ObjectYAML/wasm/start_section.yaml
===================================================================
--- test/ObjectYAML/wasm/start_section.yaml
+++ test/ObjectYAML/wasm/start_section.yaml
@@ -7,14 +7,23 @@
   - Type:            TYPE
     Signatures:
       - Index:           0
-        ReturnType:      I32
+        ReturnType:      NORESULT
         ParamTypes:
-          - F32
-          - F32
   - Type:            FUNCTION
     FunctionTypes: [ 0, 0, 0 ]
   - Type:            START
     StartFunction:   1
+  - Type:            CODE
+    Functions:
+      - Index:           0
+        Locals:
+        Body:            0B
+      - Index:           1
+        Locals:
+        Body:            0B
+      - Index:           2
+        Locals:
+        Body:            0B
 ...
 # CHECK: --- !WASM
 # CHECK: FileHeader:
Index: test/ObjectYAML/wasm/function_section.yaml
===================================================================
--- test/ObjectYAML/wasm/function_section.yaml
+++ test/ObjectYAML/wasm/function_section.yaml
@@ -14,6 +14,14 @@
           - I32
   - Type:            FUNCTION
     FunctionTypes: [ 1, 0 ]
+  - Type:            CODE
+    Functions:
+      - Index:           0
+        Locals:
+        Body:            0B
+      - Index:           1
+        Locals:
+        Body:            0B
 ...
 # CHECK: --- !WASM
 # CHECK: FileHeader:
Index: test/ObjectYAML/wasm/export_section.yaml
===================================================================
--- test/ObjectYAML/wasm/export_section.yaml
+++ test/ObjectYAML/wasm/export_section.yaml
@@ -38,6 +38,14 @@
       - Name:            table_export
         Kind:            TABLE
         Index:           0
+  - Type:            CODE
+    Functions:
+      - Index:           0
+        Locals:
+        Body:            0B
+      - Index:           1
+        Locals:
+        Body:            0B
 ...
 # CHECK: --- !WASM
 # CHECK: FileHeader:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44023.136769.patch
Type: text/x-patch
Size: 1948 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180302/69e3ca43/attachment-0001.bin>


More information about the llvm-commits mailing list