[PATCH] D43991: [WebAssembly] More uses of uint8_t for single byte values

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 2 05:22:42 PST 2018


ncw added a comment.

OK, I get it. The writer is writing out operands as SLEB128 still, //not// as uint8_t.

So the old code had `Void = -0x40`, which encodes in SLEB to `0x40`, and had `I32 = -0x01` which encodes in SLEB to `0x7F`.

This patch changed the values to their actual byte values, but they'll be mangled when they go through the SLEB operand writer (WebAssemblyMCCodeEmitter, branch for `Info.OperandType == WebAssembly::OPERAND_SIGNATURE`).


Repository:
  rL LLVM

https://reviews.llvm.org/D43991





More information about the llvm-commits mailing list