[PATCH] D43978: Write a hash of the binary as the PE Debug Directory Timestamp

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 18:32:29 PST 2018


zturner added a comment.

In https://reviews.llvm.org/D43978#1024841, @smeenai wrote:

> "Hash the PDB"
>
> I thought hashing the PDB itself was considered undesirable for speed reasons (since PDBs can get pretty large)? Or is xxHash64 fast enough that it doesn't matter?


I haven't timed it (probably should).  But, if we want reproducible builds, I dont' know of a better option.


https://reviews.llvm.org/D43978





More information about the llvm-commits mailing list