[llvm] r326510 - revert r326502: [InstCombine] allow fmul fold with less than 'fast'

[Sanjay Patel via llvm-commits]

Author: spatel
Date: Thu Mar  1 15:39:24 2018
New Revision: 326510

URL: http://llvm.org/viewvc/llvm-project?rev=326510&view=rev
Log:
revert r326502: [InstCombine] allow fmul fold with less than 'fast'

I forgot that I added tests for 'reassoc' to -reassociate, but
suprisingly that file calls -instcombine too, so it is affected.
I'll update that file and try again.

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
    llvm/trunk/test/Transforms/InstCombine/fmul.ll

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp?rev=326510&r1=326509&r2=326510&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp Thu Mar  1 15:39:24 2018
@@ -676,7 +676,7 @@ Instruction *InstCombiner::visitFMul(Bin
   //  latency of the instruction Y is amortized by the expression of X*X,
   //  and therefore Y is in a "less critical" position compared to what it
   //  was before the transformation.
-  if (I.hasAllowReassoc()) {
+  if (I.isFast()) {
     if (match(Op0, m_OneUse(m_c_FMul(m_Specific(Op1), m_Value(Y)))) &&
         Op1 != Y) {
       Value *XX = Builder.CreateFMulFMF(Op1, Op1, &I);

Modified: llvm/trunk/test/Transforms/InstCombine/fmul.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/fmul.ll?rev=326510&r1=326509&r2=326510&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/fmul.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/fmul.ll Thu Mar  1 15:39:24 2018
@@ -228,17 +228,15 @@ define float @fabs_x_fabs(float %x, floa
 }
 
 ; (X*Y) * X => (X*X) * Y
-; The transform only requires 'reassoc', but test other FMF in 
-; the commuted variants to make sure FMF propagates as expected.
 
 define float @reassoc_common_operand1(float %x, float %y) {
 ; CHECK-LABEL: @reassoc_common_operand1(
-; CHECK-NEXT:    [[TMP1:%.*]] = fmul reassoc float [[X:%.*]], [[X]]
-; CHECK-NEXT:    [[MUL2:%.*]] = fmul reassoc float [[TMP1]], [[Y:%.*]]
+; CHECK-NEXT:    [[TMP1:%.*]] = fmul fast float [[X:%.*]], [[X]]
+; CHECK-NEXT:    [[MUL2:%.*]] = fmul fast float [[TMP1]], [[Y:%.*]]
 ; CHECK-NEXT:    ret float [[MUL2]]
 ;
   %mul1 = fmul float %x, %y
-  %mul2 = fmul reassoc float %mul1, %x
+  %mul2 = fmul fast float %mul1, %x
   ret float %mul2
 }
 
@@ -260,13 +258,13 @@ define float @reassoc_common_operand2(fl
 define float @reassoc_common_operand3(float %x1, float %y) {
 ; CHECK-LABEL: @reassoc_common_operand3(
 ; CHECK-NEXT:    [[X:%.*]] = fdiv float [[X1:%.*]], 3.000000e+00
-; CHECK-NEXT:    [[TMP1:%.*]] = fmul reassoc nnan float [[X]], [[X]]
-; CHECK-NEXT:    [[MUL2:%.*]] = fmul reassoc nnan float [[TMP1]], [[Y:%.*]]
+; CHECK-NEXT:    [[TMP1:%.*]] = fmul fast float [[X]], [[X]]
+; CHECK-NEXT:    [[MUL2:%.*]] = fmul fast float [[TMP1]], [[Y:%.*]]
 ; CHECK-NEXT:    ret float [[MUL2]]
 ;
   %x = fdiv float %x1, 3.0 ; thwart complexity-based canonicalization
   %mul1 = fmul float %x, %y
-  %mul2 = fmul reassoc nnan float %x, %mul1
+  %mul2 = fmul fast float %x, %mul1
   ret float %mul2
 }
 
@@ -275,13 +273,13 @@ define float @reassoc_common_operand3(fl
 define float @reassoc_common_operand4(float %x1, float %y) {
 ; CHECK-LABEL: @reassoc_common_operand4(
 ; CHECK-NEXT:    [[X:%.*]] = fdiv float [[X1:%.*]], 3.000000e+00
-; CHECK-NEXT:    [[TMP1:%.*]] = fmul reassoc ninf float [[X]], [[X]]
-; CHECK-NEXT:    [[MUL2:%.*]] = fmul reassoc ninf float [[TMP1]], [[Y:%.*]]
+; CHECK-NEXT:    [[TMP1:%.*]] = fmul fast float [[X]], [[X]]
+; CHECK-NEXT:    [[MUL2:%.*]] = fmul fast float [[TMP1]], [[Y:%.*]]
 ; CHECK-NEXT:    ret float [[MUL2]]
 ;
   %x = fdiv float %x1, 3.0 ; thwart complexity-based canonicalization
   %mul1 = fmul float %y, %x
-  %mul2 = fmul reassoc ninf float %x, %mul1
+  %mul2 = fmul fast float %x, %mul1
   ret float %mul2
 }
 
@@ -290,12 +288,12 @@ define float @reassoc_common_operand4(fl
 define float @reassoc_common_operand_multi_use(float %x, float %y) {
 ; CHECK-LABEL: @reassoc_common_operand_multi_use(
 ; CHECK-NEXT:    [[MUL1:%.*]] = fmul float [[X:%.*]], [[Y:%.*]]
-; CHECK-NEXT:    [[MUL2:%.*]] = fmul reassoc float [[MUL1]], [[X]]
+; CHECK-NEXT:    [[MUL2:%.*]] = fmul fast float [[MUL1]], [[X]]
 ; CHECK-NEXT:    call void @use_f32(float [[MUL1]])
 ; CHECK-NEXT:    ret float [[MUL2]]
 ;
   %mul1 = fmul float %x, %y
-  %mul2 = fmul reassoc float %mul1, %x
+  %mul2 = fmul fast float %mul1, %x
   call void @use_f32(float %mul1)
   ret float %mul2
 }