[PATCH] D43706: [WebAssembly] Add except_ref as a first-class type
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 1 15:13:20 PST 2018
dschuff added inline comments.
================
Comment at: include/llvm/CodeGen/MachineValueType.h:751
case nxv32i64: return 2048;
+ case ExceptRef: return 0; // opaque type
}
----------------
This seems fishy. What would a caller actually do with a 0-size type? Do we expect this to ever be called? Should it be an unreachable instead?
Repository:
rL LLVM
https://reviews.llvm.org/D43706
More information about the llvm-commits
mailing list