[PATCH] D43964: Report an error if you try to link against .dll instead of .lib.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 1 15:08:25 PST 2018


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/Driver.cpp:161
+      error(Filename + ": bad file type. Did you specify a DLL file"
+                       " instead of an import file?");
+      break;
----------------
Nit: I'd prefer "Did you specify a DLL instead of an import library?" (DLL file -> DLL, import file -> import library)


https://reviews.llvm.org/D43964





More information about the llvm-commits mailing list